Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problematic boolean attributes #11824

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix problematic boolean attributes #11824

merged 1 commit into from
Sep 4, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Sep 4, 2024

Summary

Fixes #11746

I searched for the :disabled attribute throughout the app and didn't find any cases other than those already mentioned in the issue.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Sep 4, 2024
@momesgin momesgin added this to the v2.10.0 milestone Sep 4, 2024
@momesgin momesgin requested a review from cnotv September 4, 2024 16:57
@momesgin momesgin self-assigned this Sep 4, 2024
cnotv
cnotv approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am not able to identify manually further cases, I would opt for merging this first.

LGTM

@momesgin momesgin merged commit 9800040 into rancher:master Sep 4, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv cnotv approved these changes

Assignees

@momesgin momesgin

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Vue3: Fix problematic disabled boolean attributes
2 participants
@momesgin @cnotv